Repository navigation
fix: handle HEAD on SSE endpoint to prevent connection leaks - #3744
Jihaochang1 wants to merge 1 commit into
Conversation
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3736. If a maintainer assigns you to #3736, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Summary
Problem
When a HEAD request is sent to the SSE endpoint, the
connect_sse()function never completes, causing connection leaks and blocking keep-alive connections.Root Cause
The SSE endpoint expects an event stream, but HEAD requests only request headers without a body. The current implementation doesn't handle this case explicitly.
Fix
Add an early return in
handle_sse()for HEAD requests before callingconnect_sse(), preventing the connection leak.Changes
src/fastmcp/server/sse.py: Added HEAD request guardsrc/fastmcp/server/http.py: Added HEAD request guardCloses #3736
Type of Change
Checklist